Skip to content

FirestoreDocument: CRD/Mapper/Fuzzer #5402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 27, 2025
Merged

FirestoreDocument: CRD/Mapper/Fuzzer #5402

merged 7 commits into from
Oct 27, 2025

Conversation

@justinsb
Copy link
Collaborator

@justinsb justinsb commented Oct 10, 2025 •
edited
Loading

  • fuzzers: support filtering of objects after generation

  • controllerbuilder: support multiple services in mapper

  • controllerbuilder: support multiple proto packages in generated mapper

  • controllerbuilder: tolerate map[string]apiextensionsv1.JSON fields

  • FirestoreDocument: CRD/Mapper/Fuzzer

  • autogen: FirestoreDocument

yuwenma
yuwenma reviewed Oct 13, 2025
View reviewed changes
Copy link
Collaborator

@yuwenma yuwenma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like I should review backupschedule first. Mind uploading the PR? If it's merged, could you rebase this PR?

@yuwenma
Copy link
Collaborator

yuwenma commented Oct 13, 2025

/hold #5398

Looks like I should review backupschedule first. Mind uploading the PR? If it's merged, could you rebase this PR?

Found it

@justinsb justinsb force-pushed the firestoredocument_crd_mapper_fuzzer branch from 082fa80 to c33c973 Compare October 25, 2025 00:34
@justinsb justinsb force-pushed the firestoredocument_crd_mapper_fuzzer branch 3 times, most recently from d0730e9 to a90f86d Compare October 25, 2025 01:17
@justinsb justinsb force-pushed the firestoredocument_crd_mapper_fuzzer branch 5 times, most recently from 00199ab to 129c3be Compare October 25, 2025 02:06
@justinsb justinsb force-pushed the firestoredocument_crd_mapper_fuzzer branch 2 times, most recently from 21be7af to 5c1a757 Compare October 25, 2025 02:16
@justinsb justinsb force-pushed the firestoredocument_crd_mapper_fuzzer branch from 5c1a757 to 37545bd Compare October 25, 2025 02:43
@justinsb
Copy link
Collaborator Author

/assign @cheftako

Not as clean as it could be, because of the need to fix/improve our generators to cope with multiple proto namespaces and with the map[string]JSON

@justinsb
Copy link
Collaborator Author

/hold cancel

cheftako
cheftako reviewed Oct 27, 2025
View reviewed changes
apis/firestore/v1alpha1/document_types.go
// // The resource name of the document, for example
// // `projects/{project_id}/databases/{database_id}/documents/{document_path}`.
// // +kcc:proto:field=google.firestore.v1.Document.name
// Name *string `json:"name,omitempty"`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not objecting to commenting out a field we don't want (?yet) in the CRD. Would be good to leave a bread crumb on why?

@cheftako
Copy link
Collaborator

/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Oct 27, 2025
@google-oss-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheftako

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 3a41872 into GoogleCloudPlatform:master Oct 27, 2025
110 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cheftako cheftako cheftako left review comments

@yuwenma yuwenma yuwenma left review comments

Assignees

@cheftako cheftako

Labels

approved lgtm service:firestore

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@justinsb @yuwenma @cheftako